Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix restarting from compressed training with type embedding #2996

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix restarting from compressed training with type embedding #2996

merged 4 commits into from
Nov 20, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 16, 2023

Fix #2989.

@njzjz njzjz marked this pull request as ready for review November 16, 2023 23:05
@njzjz njzjz linked an issue Nov 16, 2023 that may be closed by this pull request
[BUG] Restarting from compressed training with type embedding throws errors #2989
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (55d678d) 75.26% compared to head (8a73399) 75.62%.
Report is 1 commits behind head on devel.

Files Patch % Lines
deepmd/model/dos.py 0.00% 1 Missing ⚠️
deepmd/model/multi.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #2996      +/-   ##
==========================================
+ Coverage   75.26%   75.62%   +0.36%     
==========================================
  Files         245      245              
  Lines       24670    24677       +7     
  Branches     1593     1593              
==========================================
+ Hits        18567    18663      +96     
+ Misses       5167     5076      -91     
- Partials      936      938       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz requested review from nahso and wanghan-iapcm November 17, 2023 22:32
@nahso
Copy link
Collaborator

nahso commented Nov 18, 2023

This bug was not detected by unit tests? Maybe we should add correcponding unit tests as well.

@njzjz
Copy link
Member Author

njzjz commented Nov 18, 2023

This bug was not detected by unit tests? Maybe we should add correcponding unit tests as well.

Good point.

@njzjz
assign -c for dp freeze
8a73399 
Signed-off-by: Jinzhe Zeng <[email protected]>
@wanghan-iapcm wanghan-iapcm merged commit a342e94 into deepmodeling:devel Nov 20, 2023
39 checks passed
@njzjz njzjz added the bug label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

@nahso nahso nahso approved these changes

Assignees
No one assigned
Labels
bug Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Restarting from compressed training with type embedding throws errors
3 participants
@njzjz @nahso @wanghan-iapcm